Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: skip git hooks #32

Merged
merged 1 commit into from
Sep 2, 2024
Merged

release: skip git hooks #32

merged 1 commit into from
Sep 2, 2024

Conversation

suvayu
Copy link
Collaborator

@suvayu suvayu commented Aug 31, 2024

Fixes: #28

Git hooks require the dev environment, however conductor may not be in
the same environment. So commit without git hooks (--no-verify).

However, if Python files are modified, then pre-commit hooks should be
run. If that's the case, exit gracefully with an appropriate message.

Git hooks require the dev environment, however conductor may not be in
the same environment.  So commit without git hooks (--no-verify).

However, if Python files are modified, then pre-commit hooks should be
run.  If that's the case, exit gracefully with an appropriate message.
@suvayu suvayu requested a review from soininen August 31, 2024 12:23
Copy link
Contributor

@soininen soininen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. We will see how it works in practice next time I try to publish a new release ;)

@suvayu suvayu merged commit 37c49fa into master Sep 2, 2024
25 checks passed
@suvayu suvayu deleted the 28-skip-hooks branch September 2, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating release tags fails because Conductor's environment is missing programs needed by Git precommit hooks
2 participants